Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/tabs): switch away from animations module #30281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 7, 2025

Reworks the tabs so they don't depend on the animations module anymore. This is both simpler and avoids some of the pitfalls of the animations module.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 7, 2025
@crisbeto crisbeto requested a review from a team as a code owner January 7, 2025 17:06
@crisbeto crisbeto requested review from andrewseguin and wagnermaciel and removed request for a team January 7, 2025 17:06
@crisbeto crisbeto force-pushed the tabs-no-animations branch 4 times, most recently from 3f06a54 to 6608cc5 Compare January 8, 2025 13:03
@crisbeto crisbeto force-pushed the tabs-no-animations branch 4 times, most recently from 8672e81 to 3e152ed Compare January 9, 2025 11:54
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jan 10, 2025
@crisbeto crisbeto removed the request for review from wagnermaciel January 10, 2025 11:31
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 10, 2025
@crisbeto crisbeto force-pushed the tabs-no-animations branch 2 times, most recently from 7d162be to b01e17c Compare January 10, 2025 22:56
Reworks the tabs so they don't depend on the animations module anymore. This is both simpler and avoids some of the pitfalls of the animations module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: material/tabs target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants